CSC207H1 Lecture Notes - Code Review, Static Variable, Instance Variable
Document Summary
These are a subset of the items found on checklists posted on the web; they also happen to be the kinds of things that tas look for in every course that involves coding. There are ve rules, listed in order of importance: all criticism must be constructive. Don"t be rude; don"t insult; don"t be sarcastic. You are responsible for each other"s code, including style, comments, and design. Does every class, method, and instance variable whether private or not! Can you write a call on each method based on only its javadoc information? (if not, it needs to be rewritten. ) Are there subsections of code that you don"t understand? (if so, there needs to be more internal commenting. ) Are any getter methods giving unnecessary access to mutable instance or static data? (for example, a method that returns a list instance variable allows anyone to modify that list. )
